Merge pull request #504 from razeware/development

v1.0.5: 🐼 Pops

.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,27 @@
+<!-- 🚀 Thank you for contributing! --->
+
+<!-- Provide a brief description of the issue here. -->
+<!-- Pretend you are explaining it to a friend, not yourself! -->
+
+### Steps to reproduce
+
+<!-- Tell us how to reproduce this issue. -->
+<!-- Please provide as much detail as possible (the more code snippets, the better)! -->
+<!-- If we cannot recreate it, we will not be able to figure out how to fix it. -->
+
+### Expected behavior
+
+<!-- Tell us what you expect to happen (what should happen once we fix the issue). -->
+
+### Actual behavior
+
+<!-- Tell us what is actually happening (what is broken/not working correctly). -->
+<!-- Please add screenshots and links to screen recordings as you see fit. -->
+
+### Environment
+
+<!-- It's really helpful to know your exact environment otherwise it can be difficult to help. -->
+
+* iOS Version:
+* raywenderlich.com App Version:
+* Device:

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,10 @@
+<!-- 🚀 Thank you for contributing! -->
+
+<!-- Describe your changes clearly and use examples if possible. -->
+
+<!-- If this PR fixes an issue, then please link to that issue. If the PR
+  is large (or likely to be), it would be prudent to open a discussion in
+  advance of the PR to avoid doing large amounts of work that might not
+  get merged. -->
+
+<!-- When this PR is merged, a new version of emitron will be pushed to Testflight automatically -->

.github/workflows/appstore-upload.yml

@@ -12,8 +12,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v1
-    - name: Switch to Xcode 11.4
-      run: sudo xcode-select --switch /Applications/Xcode_11.4.app
+    - name: Switch to Xcode 12
+      run: sudo xcode-select --switch /Applications/Xcode_12.app
     - name: Update fastlane
       run: |
         cd Emitron

.github/workflows/run_tests.yml

@@ -1,32 +1,23 @@
 name: Run tests
 
 on:
-  push:
-    branches-ignore:
-      - master
+  pull_request:
+    branches: [ development ]
 
 jobs:
   build:
-
-    runs-on: macOS-latest
-
+    runs-on: macos-latest
     steps:
     - uses: actions/checkout@v1
-    - name: Switch to Xcode 11.4
-      run: sudo xcode-select --switch /Applications/Xcode_11.4.app
+    - name: Switch to Xcode 12
+      run: sudo xcode-select -s /Applications/Xcode_12.app
     - name: Update fastlane
       run: |
         cd Emitron
         bundle install
         bundle exec fastlane -v
-    - name: Download secrets
-      env:
-        AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
-        AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
-      run: |
-        scripts/download_s3.sh development > Emitron/Emitron/Configuration/secrets.development.xcconfig
-        scripts/download_s3.sh beta > Emitron/Emitron/Configuration/secrets.beta.xcconfig
-        scripts/download_s3.sh production > Emitron/Emitron/Configuration/secrets.production.xcconfig
+    - name: Generate secrets
+      run: scripts/generate_secrets.sh
     - name: Execute fastlane
       env:
         FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT: 5

.github/workflows/testflight-beta.yml

@@ -12,8 +12,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v1
-    - name: Switch to Xcode 11.4
-      run: sudo xcode-select --switch /Applications/Xcode_11.4.app
+    - name: Switch to Xcode 12
+      run: sudo xcode-select --switch /Applications/Xcode_12.app
     - name: Update fastlane
       run: |
         cd Emitron

.github/workflows/testflight-release.yml

@@ -12,8 +12,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v1
-    - name: Switch to Xcode 11.4
-      run: sudo xcode-select --switch /Applications/Xcode_11.4.app
+    - name: Switch to Xcode 12
+      run: sudo xcode-select --switch /Applications/Xcode_12.app
     - name: Update fastlane
       run: |
         cd Emitron

CODE_OF_CONDUCT.md

@@ -0,0 +1,85 @@
+
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at
+[email protected]. All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with
+those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or
+private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an
+individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.0, available at https://www.contributor-covenant.org/version/2/0/code_of_conduct.html.
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder](https://github.com/mozilla/diversity).
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see the FAQ at https://www.contributor-covenant.org/faq. Translations are available at
+https://www.contributor-covenant.org/translations.

CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contributing to emitron
+
+👋 Welcome! Thanks for expressing an interest in contributing to the raywenderlich.com app.
+
+## Testing
+
+Once you have the project open in Xcode, select the `Emitron` scheme and use `CMD+U` to run the tests.
+
+Don't forget to add tests for any new features you add or contribute to.
+
+If you are fixing a single GitHub issue in particular, please add a test named `testGH<issue number>` to ensure that your fix is working. This will also help prevent regression.
+
+## User Account
+
+In order to use __emitron__, you must currently be a video subscriber to raywenderlich.com. If you are keen to contribute to the project, but are unable to use features of the app due to a lack of a raywenderlich.com subscription, please contact [email protected] noting which feature or area of the app you are interested in contributing to, and we should be able to set you up with appropriate access.
+
+## Access Tokens
+
+As mentioned in the readme, __emitron__ requires two secret tokens. This repo contains a sample API token, that will allow you to interact with the API, allowing you to develop the app.
+
+However, it does not contain the token that will allow access to downloads. If you wish to work on the video downloads feature, please contact [email protected] with the link to the development proposal in GitHub, and you will be provided with an appropriate token.
+
+## API Documentation
+
+__emitron__ interfaces with the raywenderlich.com API to retrieve data. You can find API documentation here:
+
+https://raywenderlich.docs.apiary.io
+
+## New Features
+
+If you would like to suggest new features, please open an issue for discussion, and include a development proposal. Although the app is open source, Razeware reserves the right to direct new feature development, and to modify, request changes to, or reject feature proposals as it sees fit.
+
+Thanks! Your work on this app will help support our worldwide community of mobile developers as they strive to improve their skills in the industry.