- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.8k
          [rcore] Add ComputeSHA256() function
          #5264
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Just a minor suggestion, maybe pick more "unique" names for the macros otherwise it might affect other code and emit "already defined" warnings. | 
| @JohnnyCena123 thanks for the addition, added some details to be reviewed | 
| @manuel5975p That's a good point, also macros can be undefined at the end of the function. | 
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
| 
 already have 2 ready yeah | 
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
| @CrackedPixel Did you review this implementation against @manuel5975p one? Are the results as expected? Out of curiosity, do both implementations have a similar performance? | 
        
          
                src/rcore.c
              
                Outdated
          
        
      | hash[6] = 0x1f83d9ab; | ||
| hash[7] = 0x5be0cd19; | ||
|  | ||
| unsigned long long const bitLen = dataSize*8; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes undefined behaviour for valid values of dataSize because both are signed integers (dataSize and the 8 literal)
| there have been some updates | 
| @JohnnyCena123 thanks for the addition. Did you verify it generates same results as the alternative implementation by @manuel5975p, #5266? | 
No description provided.