Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null pointer check to protect segfault #4627

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

null pointer check to protect segfault #4627

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc202e8
null pointer check to protect segfault
JettMonstersGoBoom Dec 21, 2024
0bc4ede
Removed memory duplication and memcpy with animations
JettMonstersGoBoom Dec 22, 2024
70171d1
Revert "Removed memory duplication and memcpy with animations"
JettMonstersGoBoom Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rmodels.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2350,6 +2350,8 @@ void UpdateModelAnimation(Model model, ModelAnimation anim, int frame)
bool updated = false; // Flag to check when anim vertex information is updated
const int vValues = mesh.vertexCount*3;

if ((mesh.boneWeights==NULL) || (mesh.boneIds==NULL)) continue; // skip if missing bone data, causes segfault without on some models

for (int vCounter = 0; vCounter < vValues; vCounter += 3)
{
mesh.animVertices[vCounter] = 0;
Expand Down
Loading