Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove rcore.h include from SDL #3475

Merged
merged 1 commit into from Oct 29, 2023
Merged

[core] Remove rcore.h include from SDL #3475

merged 1 commit into from Oct 29, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 28, 2023

Changes

  1. Very short fix to remove the rcore.h include from rcore_desktop_sdl.c (L52) so it matches the other submodules.
    References: #3420, #3429.

Environment

Changes successfully tested on Linux (Ubuntu 22.04 64-bit, gcc 11.2.0) with SDL2 (2.28.4).

Edits

1: added line marks.

@ghost
Copy link
Author

ghost commented Oct 28, 2023

@raysan5 After this change, the only other file using rcore.h is core.c.

Since rcore.h is just some defines and the CoreData struct, perhaps it would make sense to move it inside rcore.c?

@raysan5 raysan5 merged commit 01c2641 into raysan5:master Oct 29, 2023
12 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 29, 2023

Since rcore.h is just some defines and the CoreData struct, perhaps it would make sense to move it inside rcore.c?

@ubkp thanks for the review! And, yeah, that's right, rcore.h could probably be moved back to rcore.c.

@ghost ghost deleted the fix/desktop-sdl branch October 29, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant