Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zig syntax errors (0.11.0) in examples, and make it install executables correctly #3395

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

purple4pur
Copy link
Contributor

Related: #3386 #3393

Much appreciated @Not-Nik @star-tek-mb !

@raysan5
Copy link
Owner

raysan5 commented Oct 10, 2023

@Not-Nik @star-tek-mb please, could you review this PR?

@purple4pur purple4pur changed the title fix zig syntax errors (0.11.0) in examples, and make it install executables crrectly fix zig syntax errors (0.11.0) in examples, and make it install executables correctly Oct 10, 2023
@star-tek-mb
Copy link
Contributor

I don't know honestly.. I think we should either revert all recent changes. Either make a complex change with one top-level build.zig file. Because building from different directories - breaks everything.

I tried to build from top level and from src and from examples directory. It's hacking. I'm only using top level build.zig for package manager. And I'm not using examples and object files from src. So, we need better build design for using raylib with Zig, and using Zig toolchain to build .c files with raylib.

I can look at it, but on weekends.

@Not-Nik
Copy link
Contributor

Not-Nik commented Oct 10, 2023

This PR only updates the example build file to Zig 0.11. We can discuss further design changes elsewhere.

@raysan5 raysan5 merged commit 4981acb into raysan5:master Oct 13, 2023
12 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 13, 2023

@purple4pur @Not-Nik thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants