Skip to content

Commit

Permalink
[rcore] [GLFW] [SDL2] Updates CORE.Window.eventWaiting and `FLAG_WI…
Browse files Browse the repository at this point in the history
…NDOW_ALWAYS_RUN` handling (#4642)

* Add implementation for CORE.Window.eventWaiting on PLATFORM_DESKTOP_SDL

* Optimize GetFrameTime() reset

* Optimize FLAG_WINDOW_ALWAYS_RUN and GetFrameTime() reset for PLATFORM_DESKTOP_GLFW
  • Loading branch information
asdqwe authored Dec 28, 2024
1 parent 75b6b82 commit 5b82258
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
16 changes: 6 additions & 10 deletions src/platforms/rcore_desktop_glfw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1248,12 +1248,13 @@ void PollInputEvents(void)

CORE.Window.resizedLastFrame = false;

if (CORE.Window.eventWaiting) glfwWaitEvents(); // Wait for in input events before continue (drawing is paused)
if ((CORE.Window.eventWaiting) || (IsWindowState(FLAG_WINDOW_MINIMIZED) && !IsWindowState(FLAG_WINDOW_ALWAYS_RUN)))
{
glfwWaitEvents(); // Wait for in input events before continue (drawing is paused)
CORE.Time.previous = GetTime();
}
else glfwPollEvents(); // Poll input events: keyboard/mouse/window events (callbacks) -> Update keys state

// While window minimized, stop loop execution
while (IsWindowState(FLAG_WINDOW_MINIMIZED) && !IsWindowState(FLAG_WINDOW_ALWAYS_RUN)) glfwWaitEvents();

CORE.Window.shouldClose = glfwWindowShouldClose(platform.handle);

// Reset close status for next frame
Expand Down Expand Up @@ -1739,12 +1740,7 @@ static void WindowContentScaleCallback(GLFWwindow *window, float scalex, float s
static void WindowIconifyCallback(GLFWwindow *window, int iconified)
{
if (iconified) CORE.Window.flags |= FLAG_WINDOW_MINIMIZED; // The window was iconified
else
{
CORE.Window.flags &= ~FLAG_WINDOW_MINIMIZED; // The window was restored

if ((CORE.Window.flags & FLAG_WINDOW_ALWAYS_RUN) == 0) CORE.Time.previous = GetTime();
}
else CORE.Window.flags &= ~FLAG_WINDOW_MINIMIZED; // The window was restored
}

// GLFW3 WindowMaximize Callback, runs when window is maximized/restored
Expand Down
8 changes: 5 additions & 3 deletions src/platforms/rcore_desktop_sdl.c
Original file line number Diff line number Diff line change
Expand Up @@ -1378,7 +1378,11 @@ void PollInputEvents(void)

CORE.Window.resizedLastFrame = false;

if (((CORE.Window.flags & FLAG_WINDOW_MINIMIZED) > 0) && ((CORE.Window.flags & FLAG_WINDOW_ALWAYS_RUN) == 0)) SDL_WaitEvent(NULL);
if ((CORE.Window.eventWaiting) || (((CORE.Window.flags & FLAG_WINDOW_MINIMIZED) > 0) && ((CORE.Window.flags & FLAG_WINDOW_ALWAYS_RUN) == 0)))
{
SDL_WaitEvent(NULL);
CORE.Time.previous = GetTime();
}

SDL_Event event = { 0 };
while (SDL_PollEvent(&event) != 0)
Expand Down Expand Up @@ -1499,8 +1503,6 @@ void PollInputEvents(void)
if ((CORE.Window.flags & SDL_WINDOW_MAXIMIZED) > 0) CORE.Window.flags &= ~SDL_WINDOW_MAXIMIZED;
}
#endif

if ((CORE.Window.flags & FLAG_WINDOW_ALWAYS_RUN) == 0) CORE.Time.previous = GetTime();
} break;

case SDL_WINDOWEVENT_HIDDEN:
Expand Down

0 comments on commit 5b82258

Please sign in to comment.