Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improve accordion options to allow hide/show expand button #127

Conversation

tanguyantoine
Copy link
Contributor

What

  • update Accordion component so that we can programatically display/hide expand button for section

@tanguyantoine tanguyantoine force-pushed the feat/add-conditional-button-to-according branch from 1883081 to 1ddab31 Compare November 30, 2023 09:08
@tanguyantoine tanguyantoine changed the title ✨ improve accordion options to allow hide/show expand button ✨ Improve accordion options to allow hide/show expand button Nov 30, 2023
@tanguyantoine tanguyantoine force-pushed the feat/add-conditional-button-to-according branch 3 times, most recently from 80f36b7 to 69c6a9d Compare November 30, 2023 09:16
@tanguyantoine tanguyantoine force-pushed the feat/add-conditional-button-to-according branch from 69c6a9d to 4f6fd3c Compare November 30, 2023 09:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f5ccd5) 99.85% compared to head (fcac711) 99.85%.
Report is 8 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          91       91           
  Lines        1360     1365    +5     
  Branches      119      121    +2     
=======================================
+ Hits         1358     1363    +5     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raycharius
Copy link
Owner

Thanks for this great feature! I plan to get to all the PRs and a few new features a bit later this week.

@tanguyantoine
Copy link
Contributor Author

Lovely. This project is terrific. Amazing work

@tanguyantoine
Copy link
Contributor Author

up :-)

@raycharius
Copy link
Owner

Really great feature! I've included a couple of small formatting comments, and then happy to merge and get this out in the next release. Thanks!

@tanguyantoine
Copy link
Contributor Author

@raycharius I don't see any comments

@raycharius raycharius merged commit 6dff295 into raycharius:main Dec 22, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants