Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPT command (One-Time Password) in system folder #966

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miagg
Copy link
Contributor

@miagg miagg commented Oct 31, 2024

Description

This command copies One-Time Password for specified domain from Apple Password Manager.

Type of change

  • New script command

Screenshot

Dependencies / Requirements

Requires installation of Apple Passwords CLI wrapper of Apple Passwords Manager.
It also requires jq that can be also installed from homebrew.

Checklist

Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @miagg, 👋
thanks for contributing to our repository.

Please, give a check on my comments and re-request a review when you get ready.

commands/system/otp.sh Outdated Show resolved Hide resolved
commands/system/otp.sh Outdated Show resolved Hide resolved
commands/system/otp.sh Outdated Show resolved Hide resolved
commands/system/otp.sh Outdated Show resolved Hide resolved
@miagg miagg requested a review from unnamedd October 31, 2024 13:39
Copy link
Collaborator

@unnamedd unnamedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me @miagg!
Thanks for the changes! ✅

@unnamedd unnamedd added the accepted PR is ready to be merged label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted PR is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants