[ci][lint] adding precommit semgrep check #57617
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
aslonnie
approved these changes
Oct 10, 2025
|
data tests are failing? |
Signed-off-by: elliot-barn <[email protected]>
8 tasks
aslonnie
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
data team or @bveeramani should be able to help merge. otherwise, let me know.
Signed-off-by: Balaji Veeramani <[email protected]>
Signed-off-by: Balaji Veeramani <[email protected]>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| elif func_name == "isin": | ||
| if len(node.args) != 2: | ||
| raise ValueError("is_in() expects exactly two arguments") | ||
| raise ValueError("isin() expects exactly two arguments") |
There was a problem hiding this comment.
Bug: PyArrow API Mismatch Causes Expression Error
The expression evaluator's change from is_in to isin is incorrect for PyArrow expressions. PyArrow's API uses is_in(), not isin(), which will cause AttributeError at runtime when generating PyArrow expressions. This appears to be an accidental functional change that could break existing code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding pre commit and ci semgrep check for data test files
semgrep test for missing pytest.main in python/ray/data/tests/test_arrow_serialization.py: https://buildkite.com/ray-project/microcheck/builds/28269#0199cb94-4aab-4f48-9fad-776f90563d53
Pre commit local test test_should_fail.py
