Skip to content

[serve][llm] Enable engine metrics by default #57615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 10, 2025
Merged

[serve][llm] Enable engine metrics by default #57615

merged 4 commits into from
Oct 10, 2025

Conversation

eicherseiji
Copy link
Contributor

@eicherseiji eicherseiji commented Oct 9, 2025 •
edited
Loading

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run pre-commit jobs to lint the changes in this PR. (pre-commit setup)
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@eicherseiji eicherseiji changed the title [serve][llm] Enable engine metrics default [serve][llm] Enable engine metrics by default Oct 10, 2025
@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Oct 10, 2025
@eicherseiji eicherseiji marked this pull request as ready for review October 10, 2025 00:33
@eicherseiji eicherseiji requested review from a team as code owners October 10, 2025 00:33
angelinalg
angelinalg approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stamp

@eicherseiji
Update CODEOWNERS
da323da 
Signed-off-by: Seiji Eicher <[email protected]>
@ray-gardener ray-gardener bot added serve Ray Serve Related Issue observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling llm labels Oct 10, 2025
@eicherseiji
Copy link
Contributor Author

Release tests in progress: https://buildkite.com/ray-project/release/builds/62771

@kouroshHakha kouroshHakha merged commit f92189e into ray-project:master Oct 10, 2025
6 checks passed
joshkodi pushed a commit to joshkodi/ray that referenced this pull request Oct 13, 2025
@eicherseiji @joshkodi
[serve][llm] Enable engine metrics by default (ray-project#57615)
f95c72d 
Signed-off-by: Seiji Eicher <[email protected]>
Signed-off-by: Josh Kodi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abrarsheikh abrarsheikh abrarsheikh approved these changes

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@angelinalg angelinalg angelinalg approved these changes

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests llm observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling serve Ray Serve Related Issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eicherseiji @abrarsheikh @kouroshHakha @angelinalg