[core] Minor update on runtime env manager #48916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hjiang <[email protected]>
rynewang
reviewed
Nov 25, 2024
| for (const auto &uri : iter->second) { | ||
| auto uri_ref_iter = uri_reference_.find(uri); | ||
| RAY_CHECK(uri_ref_iter != uri_reference_.end()); | ||
| const auto new_ref_count = --uri_ref_iter->second; |
There was a problem hiding this comment.
I don't like -- and ++ with assignments. Let's put it 2 lines
There was a problem hiding this comment.
I don't like -- and ++ with assignments
Any reasoning? Coding practice / suggestion?
There was a problem hiding this comment.
code readability. when I read
auto y = ++x;
I need to reason: okay so y is assigned to the value before increment, not after.
but when I read
auto y = x;
++x;
there's no such cognitive load.
There was a problem hiding this comment.
wait I even made a mistake, it's after the increment not before lol. this really makes the point.
There was a problem hiding this comment.
I think this is fundamental C/C++ grammar, not something fancy and hard-to-understand.
But updated to make you happy.
Signed-off-by: hjiang <[email protected]>
Signed-off-by: hjiang <[email protected]>
jjyao
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.