[RLlib] Fix RLModuleConfig issue in action masking example #48885
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippWillms
requested review from
sven1977 and
simonsays1980
as code owners
Signed-off-by: PhilippWillms <[email protected]>
or on newest version of async-timeout it will panic and fail Signed-off-by: Lonnie Liu <[email protected]> Signed-off-by: PhilippWillms <[email protected]>
…8870) The existing reading release tests for Parquet and images aren't representative of real-world workloads: the datasets are too small and they're run on single-node clusters. --------- Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: PhilippWillms <[email protected]>
PhilippWillms
force-pushed
the
48877-action-masking-rlmodule-fix
branch
from
d0fddf6
to
a630083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In release 2.39, it was observed that the
action_masking_example.pywas no longer working. The root cause is lying in parameter handover of observation space configuration toRLModuleinstantiation.Related issue number
Closes #48877 .
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.