Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of getConstructor #233

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

NaokiTsuchiya
Copy link
Member

@NaokiTsuchiya NaokiTsuchiya commented Feb 7, 2025

Summary

Fatal error occurs with the optimized autoloader.

PHP Fatal error: Could not check compatibility between Ray\Aop\ReflectionClass::getConstructor(): ?Ray\Aop\ReflectionMethod and ReflectionClass::getConstructor(): ?ReflectionMethod, because class Ray\Aop\ReflectionMethod is not available in ...

How to Reproduce

Place the following script in the root of this project and execute it.

<?php

require __DIR__ . '/src/Reader.php';
require __DIR__ . '/src/ReflectionClass.php';

Summary by Sourcery

Bug Fixes:

  • Fixed a fatal error that occurred when using the optimized autoloader.

Summary by CodeRabbit

  • Refactor
    • Refined internal type declarations for enhanced clarity and consistency. This update does not change application behavior.

Copy link

sourcery-ai bot commented Feb 7, 2025

Reviewer's Guide by Sourcery

This pull request fixes a fatal error caused by a type incompatibility in the getConstructor method by modifying its return type to use a fully qualified \ReflectionMethod.

Updated class diagram for ReflectionClass return type fix

classDiagram
    class ReflectionClass {
      + ?\ReflectionMethod getConstructor()
      + getMethods(filter)
    }

    note for ReflectionClass "The getConstructor() method return type has been changed to the fully qualified \ReflectionMethod to fix compatibility issues."
Loading

File-Level Changes

Change Details Files
Updated the return type of the getConstructor method.
  • Changed the return type from ReflectionMethod to \ReflectionMethod in the getConstructor method.
  • Ensured that the method signature is compatible with PHP's built-in ReflectionClass expectations.
src/ReflectionClass.php

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

coderabbitai bot commented Feb 7, 2025

Walkthrough

The pull request modifies the return type declaration of the getConstructor method in the ReflectionClass. The method's return type is updated from ?ReflectionMethod to ?\ReflectionMethod, clarifying that it references the global ReflectionMethod class and remains nullable. No other code behavior or logic changes were introduced.

Changes

File(s) Change Summary
src/ReflectionClass.php Updated the getConstructor() method's return type from ?ReflectionMethod to ?\ReflectionMethod to clarify global reference.

Poem

I'm a rabbit hopping in the code field so bright,
Tweaking types with a joyful delight,
A tiny change, precise and neat,
Makes our methods align so sweet,
Bounding through code with a skip and a cheer—
Happy hops for improvements, my dear!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6cff50 and 323a70c.

📒 Files selected for processing (1)
  • src/ReflectionClass.php (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/ReflectionClass.php
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: ci / PHPUnit (8.4, windows-latest, highest, false)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NaokiTsuchiya - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4356272) to head (323a70c).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff             @@
##                 2.x      #233   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       230       230           
===========================================
  Files             28        28           
  Lines            598       598           
===========================================
  Hits             598       598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

PHP Fatal error:  Could not check compatibility between Ray\Aop\ReflectionClass::getConstructor(): ?Ray\Aop\ReflectionMethod and ReflectionClass::getConstructor(): ?ReflectionMethod, because class Ray\Aop\ReflectionMethod is not available
@koriym koriym merged commit 0eb646b into ray-di:2.x Feb 8, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants