-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix return type of getConstructor #233
Conversation
Reviewer's Guide by SourceryThis pull request fixes a fatal error caused by a type incompatibility in the getConstructor method by modifying its return type to use a fully qualified \ReflectionMethod. Updated class diagram for ReflectionClass return type fixclassDiagram
class ReflectionClass {
+ ?\ReflectionMethod getConstructor()
+ getMethods(filter)
}
note for ReflectionClass "The getConstructor() method return type has been changed to the fully qualified \ReflectionMethod to fix compatibility issues."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
WalkthroughThe pull request modifies the return type declaration of the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @NaokiTsuchiya - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #233 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 230 230
===========================================
Files 28 28
Lines 598 598
===========================================
Hits 598 598 ☔ View full report in Codecov by Sentry. |
PHP Fatal error: Could not check compatibility between Ray\Aop\ReflectionClass::getConstructor(): ?Ray\Aop\ReflectionMethod and ReflectionClass::getConstructor(): ?ReflectionMethod, because class Ray\Aop\ReflectionMethod is not available
b6cff50
to
323a70c
Compare
Summary
Fatal error occurs with the optimized autoloader.
How to Reproduce
Place the following script in the root of this project and execute it.
Summary by Sourcery
Bug Fixes:
Summary by CodeRabbit