Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multy column sorting #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Multy column sorting #24

wants to merge 1 commit into from

Conversation

m-ovs
Copy link

@m-ovs m-ovs commented Jul 30, 2021

This PR will allow table sorting by number of columns simultatiously.

Also fixed my issue with empty cell value #23 (commented in src/DataSet/index.js)

@vercel
Copy link

vercel bot commented Jul 30, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ravid7000/table-sortable/4m7HZBQtAAJaKFgwLTk27xBVsAbz
✅ Preview: https://table-sortable-git-fork-movs21-multycolsorting-ravid7000.vercel.app

ravid7000
ravid7000 reviewed Sep 21, 2021
View reviewed changes
Copy link
Owner

@ravid7000 ravid7000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this multi-column sorting is a good thing. Sorting can be done on one column at a time. I'm working on improving the sorting and introduce 3 ways sorting and that will work on single column at a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravid7000 ravid7000 ravid7000 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-ovs @ravid7000