feat: add timestamp and traceId to verification response #1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What this PR does / why we need it:
Per discussion with @yizha1, we should add more info in the verification response and the error msg from contraint template to help users pinpoint related Ratify logs.
This PR adds
timestamp
andtraceID
in verification response to help users identity the failing request easily. And the default constraint template is updated to report the timestamp and traceID when validation fails.Example:
When we get an error message from admission webhook in terminal:
We could search for traceID in Ratify logs:
And if we have ELK set up, traceID can be used to filter logs directly.
The verification response will also include traceID and timestamp fields:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1669
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change