-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add more fields to verification response #1671
Conversation
13b6142
to
89cbf05
Compare
89cbf05
to
2521995
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
@@ -22,9 +22,11 @@ import ( | |||
|
|||
const ( | |||
VerificationResultVersion = "0.1.0" | |||
ResultVersion0_2_0 = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have any documentation/Samples for each version of verification result?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have one for 0.1.0 and 1.0.0, I'll update 0.2.0 and 1.1.0 after this pr. https://ratify.dev/docs/next/reference/verification-result-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, will create an issue to track response version.
f560c1c
to
09a091b
Compare
09a091b
to
8b17053
Compare
Description
What this PR does / why we need it:
This PR is part of effort for addressing #1654
VerifierType
andVerifierName
to replacetype
andname
.ErrorReason
field to indicate root cause of an error.Remediation
field to include trouble shooting guide for the error.Subject
value in verifier report when using config policy.ReferenceDigest
to the verifierReport in V0 which is used by config poliy.This PR does not change the usage of verification response, so the verifier report should look the same as before. We'll have separate PRs to update report generation logic to carry above values.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1654
Type of change
Please delete options that are not relevant.
main
branch)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration
Checklist:
Post Merge Requirements
Helm Chart Change