Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate plugin version for ratify cli #1604

Merged
merged 14 commits into from
Jul 15, 2024

Conversation

susanshi
Copy link
Collaborator

@susanshi susanshi commented Jul 1, 2024

Description

What this PR does / why we need it:

validate the plugin version in verifier config against supported versions defined by plugins

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):

Fixes #1199

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Helm Chart Change (any edit/addition/update that is necessary for changes merged to the main branch)
  • This change requires a documentation update

How Has This Been Tested?

Test results with incompatible version.

 { "verifierReports": [ { "isSuccess": false, "name": "sbom", "message": "Original Error: (Original Error: (plugin failed with error: 'exit status 1', msg from stError '', msg from stdOut '{\n \"code\": 6,\n \"msg\": \"plugin doesn't support version 3.0.0\"\n}'), Error: verify plugin failure, Code: VERIFY_PLUGIN_FAILURE, Plugin Name: sbom, Component Type: verifier), Error: verify reference failure, Code: VERIFY_REFERENCE_FAILURE, Plugin Name: sbom, Component Type: verifier", "artifactType": "application/spdx+json" } ] }

Checklist:

  • Does the affected code have corresponding tests?
  • Are the changes documented, not just with inline documentation, but also with conceptual documentation such as an overview of a new feature, or task-based documentation like a tutorial? Consider if this change should be announced on your project blog.
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have appropriate license header?

Post Merge Requirements

  • MAINTAINERS: manually trigger the "Publish Package" workflow after merging any PR that indicates Helm Chart Change

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pkg/verifier/factory/factory.go 65.51% <100.00%> (+1.88%) ⬆️

... and 2 files with indirect coverage changes

@susanshi susanshi marked this pull request as ready for review July 4, 2024 06:09
Copy link
Collaborator

@binbin-li binbin-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix!

Copy link
Collaborator

@akashsinghal akashsinghal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susanshi susanshi enabled auto-merge (squash) July 15, 2024 01:17
@susanshi susanshi merged commit b2535b9 into ratify-project:dev Jul 15, 2024
18 checks passed
akashsinghal pushed a commit to akashsinghal/ratify that referenced this pull request Sep 13, 2024
binbin-li pushed a commit to binbin-li/ratify that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding version properties to Store and Verifier CRD
3 participants