Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding version properties to Store and Verifier CRD #1199

Closed
1 task done
susanshi opened this issue Dec 5, 2023 · 1 comment · Fixed by #1604
Closed
1 task done

Adding version properties to Store and Verifier CRD #1199

susanshi opened this issue Dec 5, 2023 · 1 comment · Fixed by #1604
Assignees
@susanshi
Labels
enhancement New feature or request
Milestone
v1.3.0

Comments

@susanshi
Copy link
Collaborator

susanshi commented Dec 5, 2023

What would you like to be added?

The internal types of store and verifier supports the version field. We should add them to the verifier property, this will be used to validate if the deployed plugin are compatible with the verifier/store CR specified.

Anything else you would like to add?

No response

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@susanshi susanshi added enhancement New feature or request triage Needs investigation labels Dec 5, 2023
@luisdlp luisdlp added this to the v1.2.0 milestone Dec 12, 2023
@luisdlp luisdlp removed the triage Needs investigation label Dec 12, 2023
@susanshi susanshi self-assigned this Mar 14, 2024
@susanshi
Copy link
Collaborator Author

susanshi commented Apr 1, 2024

CRs today already support version property. This task is to validate if ConfigMap allows for the version property

@susanshi susanshi modified the milestones: v1.2.0, v1.3.0 May 16, 2024
@susanshi susanshi mentioned this issue Jul 4, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@susanshi susanshi

Labels
enhancement New feature or request
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging a pull request may close this issue.

fix: validate plugin version for ratify cli susanshi/ratify
2 participants
@susanshi @luisdlp