Skip to content

give user more control over embedded_start_block.S contents #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2025
Merged

give user more control over embedded_start_block.S contents #2470

merged 2 commits into from
May 20, 2025

Conversation

kilograham
Copy link
Contributor

No description provided.

@kilograham kilograham added this to the 2.1.2 milestone May 16, 2025
@kilograham kilograham requested a review from will-v-pi May 16, 2025 20:44
will-v-pi
will-v-pi approved these changes May 18, 2025
View reviewed changes
Copy link
Contributor

@will-v-pi will-v-pi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although should there also be PICO_CONFIG comments for these options?

@kilograham kilograham merged commit 8066bee into develop May 20, 2025
8 checks passed
@kilograham kilograham deleted the embedded_start_block branch May 20, 2025 20:32
@kilograham
Copy link
Contributor Author

LGTM - although should there also be PICO_CONFIG comments for these options?

yes, i was just being lazy as there were none there before!

@kilograham
Copy link
Contributor Author

I think there is a separate issue somewhere (or forum thread) which lists defines without PICO_CONFIG - sounds like something @lurch might be tracking

@lurch
Copy link
Contributor

lurch commented May 21, 2025

I think there is a separate issue somewhere (or forum thread) which lists defines without PICO_CONFIG - sounds like something @lurch might be tracking

Whenever you run tools/extract_configs.py it prints out a list of #define names which start
with PICO_ but which don't have an associated PICO_CONFIG: line. But I've got no idea how many of these are "false positives"?

WARNING:__main__:Potential unmarked PICO define PICO_FLASH_SPI_CLKDIV
WARNING:__main__:Potential unmarked PICO define PICO_FLASH_SPI_RXDELAY
WARNING:__main__:Potential unmarked PICO define PICO_BOOT_STAGE2_NAME
WARNING:__main__:Potential unmarked PICO define PICO_BOOT_STAGE2_ASM
WARNING:__main__:Potential unmarked PICO define PICO_FLASH_BANK_SIZE
WARNING:__main__:Potential unmarked PICO define PICO_POWMAN_DEBUG
WARNING:__main__:Potential unmarked PICO define PICO_FLOAT_IN_RAM
WARNING:__main__:Potential unmarked PICO define PICO_LWIP_CUSTOM_LOCK_TCPIP_CORE
WARNING:__main__:Potential unmarked PICO define PICO_UNIQUE_BOARD_ID_INIT_ATTRIBUTES
WARNING:__main__:Potential unmarked PICO define PICO_UNIQUE_BOARD_ID_SIZE_BYTES
WARNING:__main__:Potential unmarked PICO define PICO_UNIQUE_BOARD_ID_INIT_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_LOWEST_IRQ_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_HIGHEST_IRQ_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_SHARED_IRQ_HANDLER_HIGHEST_ORDER_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_SHARED_IRQ_HANDLER_LOWEST_ORDER_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_EMULATE_DIVIDER
WARNING:__main__:Potential unmarked PICO define PICO_PANIC_FUNCTION_EMPTY
WARNING:__main__:Potential unmarked PICO define PICO_RAM_VECTOR_TABLE_SIZE
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_EARLIEST
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_BOOTROM_RESET
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_BOOTROM_RESET
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_H3_IRQ_REGISTERS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_EARLY_RESETS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_USB_POWER_DOWN
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_ENABLE_COPROCESSORS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_AEABI_MEM_OPS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_AEABI_BIT_OPS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_AEABI_FLOAT
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_AEABI_DOUBLE
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_CLOCKS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_POST_CLOCK_RESETS
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_RP2040_GPIO_IE_DISABLE
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_SPIN_LOCKS_RESET
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_BOOT_LOCKS_RESET
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_BOOTROM_LOCKING_ENABLE
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_MUTEX
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_IRQ_PRIORITIES
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_TLS_SETUP
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_INSTALL_RAM_VECTOR_TABLE
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_DEFAULT_ALARM_POOL
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_PER_CORE_INSTALL_STACK_GUARD
WARNING:__main__:Potential unmarked PICO define PICO_C_COMPILER_IS_CLANG
WARNING:__main__:Potential unmarked PICO define PICO_C_COMPILER_IS_GNU
WARNING:__main__:Potential unmarked PICO define PICO_ASSEMBLER_IS_CLANG
WARNING:__main__:Potential unmarked PICO define PICO_ASSEMBLER_IS_GNU
WARNING:__main__:Potential unmarked PICO define PICO_PROGRAM_BUILD_DATE
WARNING:__main__:Potential unmarked PICO define PICO_PROGRAM_NAME
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_INCLUDE_PICOBIN_IMAGE_TYPE_ITEM
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_INCLUDE_PICOBIN_VECTOR_TABLE_ITEM
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_INCLUDE_PICOBIN_ENTRY_POINT_ITEM
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_INCLUDE_PICOBIN_BLOCK
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_INCLUDE_PICOBIN_END_BLOCK
WARNING:__main__:Potential unmarked PICO define PICO_CRT0_VERSION_MAJOR
WARNING:__main__:Potential unmarked PICO define PICO_LOWEST_EXCEPTION_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_HIGHEST_EXCEPTION_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_FLASH_SAFE_EXECUTE_USE_FREERTOS_SMP
WARNING:__main__:Potential unmarked PICO define PICO_PLL_VCO_MIN_FREQ_HZ
WARNING:__main__:Potential unmarked PICO define PICO_PLL_VCO_MAX_FREQ_HZ
WARNING:__main__:Potential unmarked PICO define PICO_BINARY_INFO_USE_PINS_64
WARNING:__main__:Potential unmarked PICO define PICO_FLASH_SPI_CLKDIV
WARNING:__main__:Potential unmarked PICO define PICO_SMPS_MODE_PIN
WARNING:__main__:Potential unmarked PICO define PICO_DEFAULT_WS2812_NUM_PIXELS
WARNING:__main__:Potential unmarked PICO define PICO_VBUS_PIN
WARNING:__main__:Potential unmarked PICO define PICO_VSYS_PIN
WARNING:__main__:Potential unmarked PICO define PICO_UART1_TX_PIN
WARNING:__main__:Potential unmarked PICO define PICO_UART1_RX_PIN
WARNING:__main__:Potential unmarked PICO define PICO_I2C0_SDA_PIN
WARNING:__main__:Potential unmarked PICO define PICO_I2C0_SCL_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SPI1_CSN_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SPI1_SCK_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SPI1_TX_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SPI1_RX_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ADC_A0_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ADC_A1_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ADC_A2_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ADC_BAT_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ADC_BAT_EN_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SD_CLK_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SD_CMD_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SD_DAT0_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SD_DAT3_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SD_DAT_PIN_COUNT
WARNING:__main__:Potential unmarked PICO define PICO_DEFAULT_PIO_USB_DP_PIN
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_COLOR_PIN_BASE
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_SYNC_PIN_BASE
WARNING:__main__:Potential unmarked PICO define PICO_SD_DAT_PIN_INCREMENT
WARNING:__main__:Potential unmarked PICO define PICO_AUDIO_I2S_DATA_PIN
WARNING:__main__:Potential unmarked PICO define PICO_AUDIO_I2S_CLOCK_PIN_BASE
WARNING:__main__:Potential unmarked PICO define PICO_AUDIO_PWM_L_PIN
WARNING:__main__:Potential unmarked PICO define PICO_AUDIO_PWM_R_PIN
WARNING:__main__:Potential unmarked PICO define PICO_ON_FPGA
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_COLOR_PIN_COUNT
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_DPI_PIXEL_RSHIFT
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_DPI_PIXEL_GSHIFT
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_DPI_PIXEL_BSHIFT
WARNING:__main__:Potential unmarked PICO define PICO_SCANVIDEO_48MHZ
WARNING:__main__:Potential unmarked PICO define PICO_AUDIO_PWM_MONO_PIN
WARNING:__main__:Potential unmarked PICO define PICO_LOWEST_IRQ_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_HIGHEST_IRQ_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_SHARED_IRQ_HANDLER_HIGHEST_ORDER_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_SHARED_IRQ_HANDLER_LOWEST_ORDER_PRIORITY
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_EARLIEST
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_LATEST
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_TYPE_HW
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_TYPE_RUNTIME
WARNING:__main__:Potential unmarked PICO define PICO_RUNTIME_INIT_TYPE_PER_CORE
WARNING:__main__:Potential unmarked PICO define PICO_FLASH_SPI_CLKDIV
WARNING:__main__:Potential unmarked PICO define PICO_BOOT_STAGE2_NAME
WARNING:__main__:Potential unmarked PICO define PICO_BOOT_STAGE2_ASM

(And there's also a similar list in #2408 for the "possibly missing" PICO_CMAKE_CONFIG: and PICO_BUILD_DEFINE: CMake entries.)

@lurch
Copy link
Contributor

lurch commented May 21, 2025

a list of #define names which start with PICO_ but which don't have an associated PICO_CONFIG: line.

And in contrast to this, there are also a bunch of valid existing PICO_CONFIG: entries which don't start with either PICO_ or PARAM_ or CYW43_. (Which of course is totally fine, it just means there might be other "missing PICO_CONFIG lines" not included in the list above.)

$ git grep "PICO_CONFIG:" | grep -v ': PICO_'  | grep -v ': PARAM_' | grep -v ': CYW43_' | cut -d: -f3 | cut -d, -f1
 XOSC_HZ
 SYS_CLK_HZ
 USB_CLK_HZ
 USB_DPRAM_MAX
 XOSC_HZ
 SYS_CLK_HZ
 USB_CLK_HZ
 USB_DPRAM_MAX
 PLL_SYS_REFDIV
 PLL_SYS_VCO_FREQ_HZ
 PLL_SYS_POSTDIV1
 PLL_SYS_POSTDIV2
 SYS_CLK_VREG_VOLTAGE_AUTO_ADJUST
 SYS_CLK_VREG_VOLTAGE_MIN
 SYS_CLK_VREG_VOLTAGE_AUTO_ADJUST_DELAY_US
 PLL_USB_REFDIV
 PLL_USB_VCO_FREQ_HZ
 PLL_USB_POSTDIV1
 PLL_USB_POSTDIV2
 GPIO_IRQ_CALLBACK_ORDER_PRIORITY
 GPIO_RAW_IRQ_HANDLER_DEFAULT_ORDER_PRIORITY

@lurch lurch mentioned this pull request May 21, 2025
Open
@kilograham kilograham mentioned this pull request May 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@will-v-pi will-v-pi will-v-pi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@kilograham @lurch @will-v-pi