Comments about btstack_run_loop_execute #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some comments about how btstack_run_loop_execute does nothing in threadsafe backrgound mode.
lurch
reviewed
May 29, 2023
pico_w/bt/standalone/client.c
Outdated
| // We're using threadsafe background where poll does nothing and work is performed in a low priority IRQ | ||
| // So btstack_run_loop_execute effectively does nothing and you're free to just loop and do your own stuff | ||
| // You would have to call btstack_run_loop_execute if you were using pico_cyw43_arch_poll | ||
| #if 1 |
There was a problem hiding this comment.
Apologies for the stupid question, but why does this PR add #if 1 in client.c but #if 0 in server.c ?
There was a problem hiding this comment.
To demonstrate that both methods work?
There was a problem hiding this comment.
yeah, i also found it a bit odd(confusing); i'm planning to make some comment tweaks when i merge
|
The changes look ok to me |
kilograham
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some comments about how btstack_run_loop_execute does nothing in threadsafe backrgound mode.