drivers: staging: fbtft: Fix fb_ssd1306 driver for 128x32 Display#6691
Open
pawel-soja wants to merge 2 commits intoraspberrypi:rpi-6.6.yfrom
Open
drivers: staging: fbtft: Fix fb_ssd1306 driver for 128x32 Display#6691pawel-soja wants to merge 2 commits intoraspberrypi:rpi-6.6.yfrom
pawel-soja wants to merge 2 commits intoraspberrypi:rpi-6.6.yfrom
Conversation
Contributor
|
Slight dilemma here in that fbtft is orphaned and considered deprecated by upstream. DRM drivers (mainly mipi-dbi-spi) should be used instead. However we do have 2 downstream patches to fbtft already, so adding this isn't the end of the world. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The driver incorrectly sets the column and page addresses for a 128x32 display.
Display used is from the Environmental Sensor Board kit.
The final values of the addresses should be:
128 - 132 / 8 (bits, vertical addressing) - 1Before:

After:
