Skip to content

Kbingham/pi5/imx283 imx335 #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kbingham
Copy link
Collaborator

For reference/test only - The current patches I use when testing IMX335/IMX283 on a Pi5.

@kbingham
Copy link
Collaborator Author

@6by9 For your reference.

@6by9
Copy link
Collaborator

6by9 commented Apr 30, 2025

Thanks.
I haven't asked @davidplowman yet, but I can set up an imx335 system for him to take and do the relevant tuning gubbins with it.

I don't have an imx283. At some point it would be useful to make contact with Will and have some discussions with him.

@kbingham
Copy link
Collaborator Author

Thanks. I haven't asked @davidplowman yet, but I can set up an imx335 system for him to take and do the relevant tuning gubbins with it.

Awesome,

I don't have an imx283. At some point it would be useful to make contact with Will and have some discussions with him.

Indeed, I think this is the tuning file that Will sent me.

kbingham and others added 3 commits April 30, 2025 14:47
@kbingham kbingham force-pushed the kbingham/pi5/imx283_imx335 branch from 1066467 to 91bc52d Compare April 30, 2025 13:47
@will127534
Copy link

will127534 commented May 8, 2025

Yeah I think my IMX283 tuning is a bit off, it is also generated quite early in the RPI5 release, same for IMX585.
Probably going to generate a new set of calibration images soon but I always have a hard time trying to source proper ~6500K ~ 7000K reference light other than waiting for cloudy day in California.

What is the issue? Also just curious, what is the thing that relates IMX335 and IMX283?

@kbingham
Copy link
Collaborator Author

kbingham commented May 8, 2025

What is the issue? Also just curious, what is the thing that relates IMX335 and IMX283?

My board has an IMX335 and an IMX283 connected to it ;-)

@kbingham
Copy link
Collaborator Author

kbingham commented May 8, 2025

Maybe I should consider giving (loaning :D) my OneInchEye to David next week when I see him ...

@6by9
Copy link
Collaborator

6by9 commented May 8, 2025

Let's talk with @naushir and @davidplowman
The driver is already upstream, so it's only a matter of the tuning files and cam_helper.
It'd be useful to have a dtoverlay in our kernel tree too.

@will127534 Do let us know if you're doing another production run - it's useful to have a sample of all sensors that have some level of support on the Pi.

@naushir
Copy link
Collaborator

naushir commented May 8, 2025

If the device drivers are available upstream, we should perhaps merge the cam helper and tuning files to upstream libcamera. After that I can merge this back to our downstream tree.

@6by9
Copy link
Collaborator

6by9 commented May 8, 2025

The driver was merged upstream in 6.11 by Kieran - https://github.com/torvalds/linux/commits/master/drivers/media/i2c/imx283.c
So other than the missing overlay, the kernel work is done. libcamera I generally leave to you guys :-)

@will127534
Copy link

will127534 commented May 9, 2025

@6by9 Send me an email or DM me an address on RPI forum (will127534) and I can send you one : )
I always keep a few around for my own projects or warranty replacements.

@naushir
Copy link
Collaborator

naushir commented May 9, 2025

@will127534 can you send me an email - you can find my address in the sign-off tag in commit 2993e79 (I'd rather not write it directly on here). I'll send you details on how to get some devices shipped to us. We will try to arrange all the shipment from here including payment as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants