-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG Support #23
SVG Support #23
Conversation
…rs/svgAttrs.scala:8: Attrs is already defined as trait Attrs
I moved everything to this PR, so we can work together on the same branch. |
I don't know why this PR was closed. And for some strange reason I am not able to reopen it. @doofin is it possible for you to reopen this PR? |
I have no permission to edit ,I guess you have to add me to the collaborator list? It seems that you have deleted the |
I have add you to the collaborator list of my repo: https://github.com/doofin/scala-dom-types , we can work on that temporarily if you like |
@doofin I've just added you as a collaborator to this project, you can probably recreate this branch after accepting the invite |
@raquo I haven't receive any invitation and git still complains permission denied when I tried to push,maybe try again? |
@doofin you should be able to see your invite here: https://github.com/raquo/scala-dom-types/invitations |
@raquo thanks! It works |
For reference:
https://github.com/lihaoyi/scalatags/blob/44cbd0602d40186d33d39b8d4a259f681d2e4a3b/scalatags/shared/src/main/scala/scalatags/generic/SvgTags.scala
https://github.com/lihaoyi/scalatags/blob/44cbd0602d40186d33d39b8d4a259f681d2e4a3b/scalatags/js/src/main/scala/scalatags/jsdom/SvgTags.scala
svg/Attrs.scala
trait with typed listings of SVG attributessvg/Tags.scala
(might need multiple files similar to how HTML tags are done)jsdom/defs/package.scala
SvgAttr
(I don't think we should reuse Attr for that), and a canonical builder for it (seecanonical
dir). Don't want to accidentally use SVG attrs on HTML elements, and without Track parent tag of properties #13 not sure what else we can do. Not sure about this, and IIRC you're not using these concrete classes in Outwatch, so I guess I'll need to think about this some time later.Tag
class, I think no need to createSvgTag
, maybe Tag[SVGElement] would be enough. Not sure.fixes #20