Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding clicked point throws an error with MeshBasicMaterial #88

Open
wolfv opened this issue Jun 11, 2020 · 4 comments
Open

Adding clicked point throws an error with MeshBasicMaterial #88

wolfv opened this issue Jun 11, 2020 · 4 comments

Comments

@wolfv
Copy link
Contributor

wolfv commented Jun 11, 2020

The assert when setting the color doesn't seem to properly work.

I tried to check to make sure only one threejs version is on the page.
@wolfv
Copy link
Contributor Author

wolfv commented Jun 11, 2020

So the problem seems to be that Amphion is sending a MeshBasicMaterial and tests for a MeshStandardMaterial...

@himanshuc3
Copy link
Contributor

himanshuc3 commented Jun 12, 2020 •
edited
Loading

Is Zethus being used as a component or are we talking about the web application?

@wolfv
Copy link
Contributor Author

wolfv commented Jun 12, 2020

It does not matter as far as I can tell. Anytime you are adding a clicked point you will see this error.

That is where the assert is that gets triggered.
It seems very restrictive to test only for Basic Material (there are some other material types in Three JS).
It fails for Standard Material.

I suggest to switch to assertMaterial or remove this check entirely.

https://github.com/rapyuta-robotics/amphion/blob/fc7755265c563e01a25d87d3a70b6df4a71a3f1b/src/utils/transform.ts#L27-L37

@himanshuc3
Copy link
Contributor

Got it. Will create a bugfix release and deploy today if possible.

hbcarlos added a commit to RoboStack/amphion that referenced this issue Jun 12, 2020
@hbcarlos
Fix: rapyuta-robotics/zethus#88
207d6e1 
assertIsMeshBasicMaterial to assertIsMaterial
hbcarlos added a commit to RoboStack/amphion that referenced this issue Jun 12, 2020
@hbcarlos
Fixed: rapyuta-robotics/zethus#88
270e5c6
hbcarlos added a commit to RoboStack/zethus that referenced this issue Jun 12, 2020
@hbcarlos
Fixed: rapyuta-robotics#88
8a39300
hbcarlos added a commit to RoboStack/amphion that referenced this issue Jun 16, 2020
@hbcarlos
Revert "Fixed: rapyuta-robotics/zethus#88"
cee09c0 
This reverts commit 270e5c6.
hbcarlos added a commit to RoboStack/zethus that referenced this issue Jun 28, 2020
@hbcarlos
Revert "Fixed: rapyuta-robotics#88"
92f5f5b 
This reverts commit 8a39300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wolfv @himanshuc3