forked from rpoleski/MulensModel
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removed deprecated from FitData.get_residuals(), flake8
- Loading branch information
1 parent
ee68f57
commit 902838a
Showing
1 changed file
with
23 additions
and
34 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
902838a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change in
get_residuals()
- I could have missed that it's not just removing parts of the code.The second change I don't get - you're removing something that @jenniferyee added recently?
The last change is OK, but it inspired me to make a note: remove the code that was deprecated in v2, but not in v3.
902838a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpoleski the method
get_d_A_d_rho()
is defined twice (lines 654 and 689). Flake8 was complaining and I commented one of them: which one should be removed then?I can correct it today before going to the next deprecated cases.
902838a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug introduced by Jen in Version3_1 branch. Please leave the 2 functions as they were before. I've informed Jen that she should take care of that (link).