Skip to content

Commit

Permalink
Change rw-file-cache minimum version
Browse files Browse the repository at this point in the history
  • Loading branch information
Jordan Hall committed Jan 24, 2018
1 parent 2e35eab commit cfeb932
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
],
"require": {
"php": ">=5.3",
"rapidwebltd/rw-file-cache": "^1.0"
"rapidwebltd/rw-file-cache": "^1.2.5"
},
"require-dev": {
"phpunit/phpunit": "^5.7"
Expand Down

5 comments on commit cfeb932

@Jono20201
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would be work making this an optional dependency?

@DivineOmega
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jono20201 I want caching by default to prevent unnecessary load on the gov.uk servers. It might be worth allowing people to supply their own cache drivers though.

@DivineOmega
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created a new issue regarding this (#2).

@Jono20201
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DivineOmega The only reason I say this is because I'm using it within a Laravel application and it is an extra dependency I'd rather not have if I am not going to be using it.

@DivineOmega
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jono20201 That's understandable. I've used this package inside of Laravel projects as well. Once issue #2 is resolved, I'll consider removing rw-file-cache as a dependency.

Please sign in to comment.