-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT-unspill: fix potential deadlock #501
JIT-unspill: fix potential deadlock #501
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #501 +/- ##
===============================================
+ Coverage 90.42% 91.35% +0.93%
===============================================
Files 15 18 +3
Lines 1128 1435 +307
===============================================
+ Hits 1020 1311 +291
- Misses 108 124 +16
Continue to review full report at Codecov.
|
try: | ||
hostfile.maybe_evict(self.__sizeof__()) | ||
finally: | ||
hostfile.lock.release() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for future reading: hostfile.lock
is an RLock
, so this block is ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @madsbk !
@gpucibot merge |
Fixes a deadlock where multiple threads accesses
ProxifyHostFile.maybe_evict()
but none of them can acquire both theProxifyHostFile
lock and theProxyObject
lock simultaneously.Should fix_ rapidsai/gpu-bdb#162 (comment)