Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heterogeneous Link Prediction Example for cuGraph-PyG #104

Merged
merged 28 commits into from
Feb 3, 2025

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Jan 6, 2025

Adds a heterogeneous link prediction example for cuGraph-PyG that uses the Taobao dataset. Loosely based on the Taobao example from the PyG repository.

Adds ability to specify fanout as a dictionary to better align with PyG API.

Fixes a bug where the number of negative samples was calculated incorrectly, causing additional unwanted negative samples to be generated.

Updates the negative sampling call to match the new behavior added in rapidsai/cugraph#4885

Merge after rapidsai/cugraph#4898

Copy link

copy-pr-bot bot commented Jan 6, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@alexbarghi-nv alexbarghi-nv self-assigned this Jan 6, 2025
@alexbarghi-nv alexbarghi-nv added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 6, 2025
@alexbarghi-nv alexbarghi-nv added this to the 25.02 milestone Jan 6, 2025
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only a correction to the type hints. Method behavior is unchanged.

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review January 28, 2025 23:43
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner January 28, 2025 23:43
@alexbarghi-nv
Copy link
Member Author

Confirmed this is working on 8xH100

@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner January 31, 2025 21:05
common:
- output_types: [conda]
packages:
- pytorch>=2.3,<2.6a0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused, do we also need an upper bound pinning for pip packages? It appears to be reusing *pytorch_pip below, which won't have the <2.6a0 upper bound.

@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit dd543dc into rapidsai:branch-25.02 Feb 3, 2025
82 checks passed
@alexbarghi-nv alexbarghi-nv deleted the hetero-examples-pyg branch February 3, 2025 17:46
rapids-bot bot pushed a commit that referenced this pull request Feb 4, 2025
Now that all features supported by the Dask API are available in the new API, we are deprecating the Dask API.  It will be removed in release 25.06.

Merge after #104 
Closes #86

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Tingyu Wang (https://github.com/tingyu66)

URL: #118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants