Remove unnecessary synchronization (miss-sync) during Parquet reading (Part 1: device_scalar) #19055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scalar Signed-off-by: Jigao Luo <[email protected]>
Contributor
Author
bdice
added
improvement
GregoryKimball
requested review from
mhaseeb123 and
vuule
and removed request for
pmattione-nvidia and
vyasr
Contributor
|
/ok to test |
@vuule, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/ |
vuule
approved these changes
Jun 2, 2025
Contributor
|
/ok to test a564a9b |
shrshi
approved these changes
Jun 2, 2025
mhaseeb123
approved these changes
Jun 2, 2025
Contributor
|
/ok to test 396f14c |
Contributor
|
/merge |
Contributor
Author
|
Is there something I need to fix? I’m also confused about the narwals-tests output. Could you help me understand it? |
Contributor
Contributor
|
/ok to test 0720b03 |
Contributor
|
/merge |
Contributor
|
Thank you @JigaoLuo !! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For issue #18967, this PR is the first part of merging the PR Draft #18968. In this PR,
device_scalarutilizes explicitly host pinned memory as its internal bounce buffer.Checklist