You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe. @MarcoGorelli has reported a number of issues to cudf stemming from narwhals. narwhals is sussing out a number of issues that we don't currently see anywhere else except likely in the pandas test suite, where our pass rate remains too low to be used as an absolute pass/fail indicator in CI.
Describe the solution you'd like
We would benefit from running the narwhals test suite as part of cudf's CI similarly to how we run the pandas test suite.
Describe alternatives you've considered
None
Additional context
The narwhals tests look like they take <5 min, so they shouldn't be too expensive, but I would still recommend only running them on a single CUDA ver/Python ver/arch combination to limit resource usage.
The text was updated successfully, but these errors were encountered:
Awesome. From a quick look at the configuration it looks like the test suite automatically selects which narwhals backends to test. Is there a way to select some explicitly? If not, would you be open to adding some custom flags to your pytest_addoption implementation to allow for selecting the pandas tests, polars tests, etc? The reason that I ask is that if your test suite is that fast, we might even want to consider running it for each of our front-ends separately, i.e. run the cuDF tests, then run the pandas tests with cudf.pandas enabled, then run the polars test suite with GPU support via cuDF enabled.
Is your feature request related to a problem? Please describe.
@MarcoGorelli has reported a number of issues to cudf stemming from narwhals. narwhals is sussing out a number of issues that we don't currently see anywhere else except likely in the pandas test suite, where our pass rate remains too low to be used as an absolute pass/fail indicator in CI.
Describe the solution you'd like
We would benefit from running the narwhals test suite as part of cudf's CI similarly to how we run the pandas test suite.
Describe alternatives you've considered
None
Additional context
The narwhals tests look like they take <5 min, so they shouldn't be too expensive, but I would still recommend only running them on a single CUDA ver/Python ver/arch combination to limit resource usage.
The text was updated successfully, but these errors were encountered: