Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: symbol-map #1005

Merged
merged 4 commits into from
Mar 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/docs/config.md
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ Has no default values. Example values are shown below:
```toml
fonts.symbol-map = [
// covers: '⊗','⊘','⊙'
{ start = "2297", end = "2299", font-family = "Cascadia Code Nerd Font" }
{ start = "2297", end = "2299", font-family = "Cascadia Code NF" }
]
```

Expand All @@ -305,7 +305,7 @@ In case you would like to map many codepoints:
```toml
fonts.symbol-map = [
{ start = "E0A0", end = "E0A3", font-family = "PowerlineSymbols" },
{ start = "E0C0", end = "E0C7", font-family = "PowerlineSymbols" },
{ start = "E0C0", end = "E0C7", font-family = "PowerlineSymbols" }
]
```

Expand Down
6 changes: 5 additions & 1 deletion docs/docs/releases.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,12 @@ language: 'en'

## 0.2.9 (unreleased)

- Support to symbol map configuration: `fonts.symbol-map`:
```toml
# covers: '⊗','⊘','⊙'
fonts.symbol-map = [{ start = "2297", end = "2299", font-family = "Cascadia Code NF" }]
```
- Add Switch to Next/Prev Split or Tab command by [@vlabo](https://github.com/vlabo).
- Support to symbol map configuration: `fonts.symbol-map`.
- Fix issue whenever the first main font cannot be found.

## 0.2.8
Expand Down
4 changes: 2 additions & 2 deletions frontends/rioterm/src/context/grid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ impl<T: rio_backend::event::EventListener> ContextGrid<T> {
self.current += 1;
}

return true;
true
}

#[inline]
Expand All @@ -179,7 +179,7 @@ impl<T: rio_backend::event::EventListener> ContextGrid<T> {
} else {
self.current -= 1;
}
return true;
true
}

#[inline]
Expand Down
9 changes: 8 additions & 1 deletion rio-backend/src/config/defaults.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,14 @@ pub fn default_config_file_content() -> String {
# [fonts]
# hinting = false
#
# Example:
# You can also map the specified Unicode codepoints to a particular font.
# [fonts]
# symbol-map = [
# // covers: '⊗','⊘','⊙'
# { start = "2297", end = "2299", font-family = "Cascadia Code NF" }
# ]
#
# Simple example:
# [fonts]
# size = 18
#
Expand Down
28 changes: 16 additions & 12 deletions rio-backend/src/config/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ mod tests {
use super::*;
use colors::{hex_to_color_arr, hex_to_color_wgpu};
use std::io::Write;
use sugarloaf::font::fonts::parse_unicode;

fn tmp_dir() -> PathBuf {
std::env::temp_dir()
Expand Down Expand Up @@ -1044,29 +1045,32 @@ mod tests {

#[test]
fn test_symbol_map() {
fn unsafe_parse_unicode(input: &str) -> char {
let unicode = u32::from_str_radix(input, 16).unwrap();
char::from_u32(unicode).unwrap()
}

let result = create_temporary_config(
"symbol-map",
r#"
fonts.symbol-map = [
// covers: '⊗','⊘','⊙'
{ start = "2297", end = "2299", font-family = "PowerlineSymbols" }
# covers: '⊗','⊘','⊙'
{ start = "2297", end = "2299", font-family = "PowerlineSymbols" },
{ start = "E0C0", end = "E0C7", font-family = "Cascadia Code NF" },
]
"#,
);

assert!(result.fonts.symbol_map.is_some());
let symbol_map = result.fonts.symbol_map.unwrap();
assert_eq!(symbol_map.len(), 1);
assert_eq!(symbol_map.len(), 2);
assert_eq!(symbol_map[0].font_family, "PowerlineSymbols");
assert_eq!(symbol_map[0].start, "E0C0");
assert_eq!(symbol_map[0].end, "E0C7");
assert_eq!(symbol_map[0].start, "2297");
assert_eq!(symbol_map[0].end, "2299");

assert_eq!(parse_unicode(&symbol_map[0].start), Some('\u{2297}'));
assert_eq!(parse_unicode(&symbol_map[0].end), Some('\u{2299}'));

assert_eq!(symbol_map[1].font_family, "Cascadia Code NF");
assert_eq!(symbol_map[1].start, "E0C0");
assert_eq!(symbol_map[1].end, "E0C7");

assert_eq!(unsafe_parse_unicode(&symbol_map[0].start), '\u{E0C0}');
assert_eq!(unsafe_parse_unicode(&symbol_map[0].end), '\u{E0C7}');
assert_eq!(parse_unicode(&symbol_map[1].start), Some('\u{E0C0}'));
assert_eq!(parse_unicode(&symbol_map[1].end), Some('\u{E0C7}'));
}
}
10 changes: 10 additions & 0 deletions sugarloaf/src/font/fonts.rs
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,16 @@ pub struct SugarloafFonts {
pub symbol_map: Option<Vec<SymbolMap>>,
}

pub fn parse_unicode(input: &str) -> Option<char> {
if let Ok(unicode) = u32::from_str_radix(input, 16) {
if let Some(result) = char::from_u32(unicode) {
return Some(result);
}
}

None
}

impl Default for SugarloafFonts {
fn default() -> SugarloafFonts {
SugarloafFonts {
Expand Down
77 changes: 75 additions & 2 deletions sugarloaf/src/font/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pub mod loader;
pub const FONT_ID_REGULAR: usize = 0;

use crate::font::constants::*;
use crate::font::fonts::{SugarloafFontStyle, SugarloafFontWidth};
use crate::font::fonts::{parse_unicode, SugarloafFontStyle, SugarloafFontWidth};
use crate::font_introspector::text::cluster::Parser;
use crate::font_introspector::text::cluster::Token;
use crate::font_introspector::text::cluster::{CharCluster, Status};
Expand All @@ -21,6 +21,7 @@ use lru::LruCache;
use parking_lot::FairMutex;
use rustc_hash::FxHashMap;
use std::num::NonZeroUsize;
use std::ops::Range;
use std::path::PathBuf;
use std::sync::Arc;

Expand All @@ -34,8 +35,8 @@ pub fn lookup_for_font_match(
) -> Option<(usize, bool)> {
let mut search_result = None;
let mut font_synth = Synthesis::default();
let fonts_len: usize = library.inner.len();

let fonts_len: usize = library.inner.len();
for font_id in 0..fonts_len {
let mut is_emoji = false;

Expand Down Expand Up @@ -118,10 +119,16 @@ impl Default for FontLibrary {
}
}

pub struct SymbolMap {
pub font_index: usize,
pub range: Range<char>,
}

pub struct FontLibraryData {
pub ui: FontArc,
// Standard is fallback for everything, it is also the inner number 0
pub inner: FxHashMap<usize, FontData>,
pub symbol_maps: Option<Vec<SymbolMap>>,
pub stash: LruCache<usize, SharedData>,
pub hinting: bool,
}
Expand All @@ -133,6 +140,7 @@ impl Default for FontLibraryData {
inner: FxHashMap::default(),
stash: LruCache::new(NonZeroUsize::new(2).unwrap()),
hinting: true,
symbol_maps: None,
}
}
}
Expand Down Expand Up @@ -160,6 +168,15 @@ impl FontLibraryData {
return Some((0, false));
}

// First check symbol map before lookup_for_font_match
if let Some(symbol_maps) = &self.symbol_maps {
for symbol_map in symbol_maps {
if symbol_map.range.contains(&ch) {
return Some((symbol_map.font_index, false));
}
}
}

let is_italic = fragment_style.font_attrs.style() == Style::Italic;
let is_bold = fragment_style.font_attrs.weight() == Weight::BOLD;

Expand Down Expand Up @@ -384,6 +401,62 @@ impl FontLibraryData {
}
}

// TODO: Currently, it will naively just extend fonts from symbol_map
// without even look if the font has been loaded before.
// Considering that we drop the font data that's inactive should be ok but
// it will cost a bit more time to initialize.
//
// Considering we receive via config
// [{ start = "2297", end = "2299", font-family = "Cascadia Code NF" },
// { start = "2296", end = "2297", font-family = "Cascadia Code NF" }]
//
// Will become:
// [{ start = "2297", end = "2299", font_index = Some(1) },
// { start = "2296", end = "2297", font_index = Some(1) }]
//
// TODO: We should have a new symbol map internally
// { range = '2296'..'2297', font_index = Some(1) }]
if let Some(symbol_map) = spec.symbol_map {
let mut symbol_maps = Vec::default();
for extra_font_from_symbol_map in symbol_map {
match find_font(
&db,
SugarloafFont {
family: extra_font_from_symbol_map.font_family,
..SugarloafFont::default()
},
true,
true,
) {
FindResult::Found(data) => {
if let Some(start) =
parse_unicode(&extra_font_from_symbol_map.start)
{
if let Some(end) =
parse_unicode(&extra_font_from_symbol_map.end)
{
self.insert(data);

symbol_maps.push(SymbolMap {
range: start..end,
font_index: self.len() - 1,
});

continue;
}
}

warn!("symbol-map: Failed to parse start and end values");
}
FindResult::NotFound(spec) => {
fonts_not_fount.push(spec);
}
}
}

self.symbol_maps = Some(symbol_maps);
}

fonts_not_fount
}

Expand Down
Loading