caching NodeModule.path and NodeModule.maxVersionInSameMajor getters
#126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SukkaW
commented
Aug 12, 2023
| @@ -152,7 +152,7 @@ export default class Workspace { | |||
| } | |||
| } | |||
|
|
|||
| return this._isPnpm!; | |||
| return this._isPnpm; | |||
There was a problem hiding this comment.
The non-null assertion here is no longer needed. The typescript can identify that the this._isPnpm here can not be null.
|
Available from [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pathgetter has 8 references, and themaxVersionInSameMajorgetter has 3 references:The PR prevents
path.joinandsemverMaxSatisfyingfrom being called multiple times by caching the return value.