Skip to content

Update crate thiserror and others #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

martinfrances107
Copy link

I like this project ... it is really useful.

In a way this is a field report from a upstream user.

The leptos framework makes extensive use of gloo
I have a application based on leptos ..
and am tracking down why there are many duplicate versions version of certain crates being built.
( duplicate but with different version numbers )

I want to upgrade "thiserror" to a modern version

This is open source, so for crates I depend on, I am happy to go a bit further and do all the basic maintence
I can see, So I did the following

  • ran cargo update
  • Moved thiserror up into the root workspace so I only have to bump the version to 2.0 once.
  • Updated/Fixed deprecated fn names.

* Moved thiserror up into the root workspace
  so I only have to bump the version to 2.0 once.
* Updated/Fixed deprecated fn names.
…zyLock

It Fixed this build error

error: package `once_cell v1.21.3` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.64.0
error: package `tracing-core v0.1.34` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0
Bumped rust-version to 1.71.1

error: package `bumpalo v3.19.0` cannot be built because it requires rustc 1.71.1 or newer, while the currently active rustc version is 1.64.0

Bumped this github action

-  uses: jetli/[email protected]
+  uses: jetli/[email protected]

BugFix

-#[cfg(feature = "browser_test")]
+#[cfg(feature = "browser-test")]
Bumped rust-version to 1.82

error: package `icu_normalizer_data v2.0.0` cannot be built because it requires rustc 1.82 or newer, while the currently active rustc version is 1.71.1
However, as of January 2024, the WASI standard was rebased on the Component Model, leading to the release of WASIp2, which is now referred to as wasm32-wasip2.
 The wasm32-wasi target was renamed to wasm32-wasip1 to avoid confusion with the new target.
because if there are any incompatibilities between version numbers
it is difficult to debug.

 [workspace.dependencies]
-thiserror = { version = "2.0" }
+thiserror = "2.0"
+wasm-bindgen-futures = "0.4.4"
+wasm-bindgen = "0.2"
+wasm-bindgen-test = "0.3.4"
+js-sys = "0.3.77"
@martinfrances107
Copy link
Author

Of the three remaining failure, it looks like firefox is reaching out of the network to preform some ad blocking funciton ... The CORS policy is blocking a "fetch" request for a URL on the internet .. and failing

Hmm not sure how to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant