Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement etcd snapshot restore skeleton #736

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Sep 9, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #500

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev force-pushed the snapshot-restore branch 3 times, most recently from 4e3f14d to 116a345 Compare September 13, 2024 08:26
@Danil-Grigorev Danil-Grigorev marked this pull request as ready for review September 24, 2024 09:36
@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner September 24, 2024 09:36
@Danil-Grigorev Danil-Grigorev force-pushed the snapshot-restore branch 6 times, most recently from 5e8ffff to 580e076 Compare October 1, 2024 08:48
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is WIP no comments are blocking merging the PR, thanks a lot for taking care of it @Danil-Grigorev

Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Danil-Grigorev

@alexander-demicev alexander-demicev merged commit 54fc8ff into rancher:main Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[etcdsnapshot&restore] Implement ETCDSnapshotRestore controller
3 participants