Handle Azure NIC reservation during VM deletion#359
Open
apoorvajagtap wants to merge 1 commit intorancher:masterfrom
Open
Handle Azure NIC reservation during VM deletion#359apoorvajagtap wants to merge 1 commit intorancher:masterfrom
apoorvajagtap wants to merge 1 commit intorancher:masterfrom
Conversation
apoorvajagtap
force-pushed
the
8916-azureresources
branch
4 times, most recently
from
da29daa to
a1a26d4
Compare
Author
|
I think proactively detaching NICs from VMs during cleanup could be a more robust approach, as it would help avoid orphaned resources and also allow for better parallelization. If this sounds like a preferable alternative, I’d be happy to explore its feasibility. (ref) |
apoorvajagtap
changed the title
jakefhyde
reviewed
Feb 10, 2026
apoorvajagtap
force-pushed
the
8916-azureresources
branch
from
a1a26d4 to
38098d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure may temporarily retain NIC reservations after VM deletion or failed VM provisioning, causing cleanup to fail with the
NicReservedForAnotherVmerror.This commit:
DeleteNetworkInterfaceIfExistswhen NICs are temporarily reservedmaxRetryDuration(180 seconds) before re-attempting deletionThis improves cleanup reliability by preventing orphaned NICs and, consequently, orphaned Public IPs.