Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a package list file per image in the channel #66

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

davidcassany
Copy link
Collaborator

@davidcassany davidcassany self-assigned this Nov 28, 2024
Copy link
Collaborator

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had doubts whether the tarball is necessary or not, but I think it's for the best in all cases where the limit is high or absent, as that will generate a lot of files.

@@ -166,6 +166,11 @@ function process_repo() {
local intermediate_entry="{\"uri\":\"$image_uri\",\"created\":\"$image_creation_date\",\"version\":\"$version\",\"managedOSVersionName\":\"$managed_os_version_name\",\"displayName\":\"$display_name\",\"platforms\":$platforms}"
echo "Intermediate: $intermediate_entry"
local intermediate_list=("${intermediate_list[@]}" "$intermediate_entry")
if [[ "${repo_type}" == "os" ]]; then
podman pull "${image_uri}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find podman within the GitHub Actions runner image, you may have to add a apt-get -y install podman step in the workflow.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was looking in the wrong place :P

@davidcassany davidcassany merged commit 5a674a3 into rancher:main Nov 28, 2024
@davidcassany davidcassany deleted the create_packages_list_file branch November 28, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants