Updated contents related to external TLS termination #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed reference to much older reference to v0.25, as it's now on version v1.2 4 years later. Updated instructions on applying needed change via manifest file. Added clearer title for NGINX config, so installer knows where config should be applied.
jtravee
suggested changes
Jul 1, 2022
content/rancher/v2.6/en/installation/install-rancher-on-k8s/chart-options/_index.md
Outdated
Show resolved
Hide resolved
content/rancher/v2.6/en/installation/install-rancher-on-k8s/chart-options/_index.md
Outdated
Show resolved
Hide resolved
snasovich
requested changes
Jul 1, 2022
| In NGINX v0.25, the behavior of NGINX has [changed](https://github.com/kubernetes/ingress-nginx/blob/master/Changelog.md#0220) regarding forwarding headers and external TLS termination. Therefore, in the scenario that you are using external TLS termination configuration with NGINX v0.25, you must edit the `cluster.yml` to enable the `use-forwarded-headers` option for ingress: | ||
| In the scenario that you are using external TLS termination configuration with NGINX, you must enable the `use-forwarded-headers` option for ingress: | ||
|
|
||
| Create a `/var/lib/rancher/rke2/server/manifests/rke2-ingress-nginx-config.yaml` file with the following contents on one of your rke2 nodes. |
There was a problem hiding this comment.
This assumes we're using RKE2 while this page doesn't seem to be RKE2 specific - the only occurrences of "RKE2" term are in added content.
I think we should cover non-RKE2 cases as well.
Adding @kinarashah as "all things NGINX" expert to review as well.
…art-options/_index.md Co-authored-by: Jen Travinski <[email protected]>
…art-options/_index.md Co-authored-by: Jen Travinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed reference to much older reference to v0.25, as it's now on version v1.2 4 years later.
Updated instructions on applying needed change via manifest file.
Added clearer title for NGINX config, so installer knows where config should be applied.