Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node Scheduling / Node Name option in Workloads page #12962

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

torchiaf
Copy link
Member

@torchiaf torchiaf commented Jan 2, 2025

Summary

Fixes #12939

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Signed-off-by: Francesco Torchia <[email protected]>
Signed-off-by: Francesco Torchia <[email protected]>
@torchiaf torchiaf added this to the v2.11.0 milestone Jan 2, 2025
@torchiaf torchiaf requested review from cnotv and a110605 and removed request for cnotv January 2, 2025 11:07
Signed-off-by: Francesco Torchia <[email protected]>
Copy link
Member

@cnotv cnotv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported issue seems solved.

LGTM

@torchiaf torchiaf merged commit 8715067 into rancher:master Jan 7, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Scheduling option is ignored when creating/edit workloads
3 participants