test: cover clusterclass in e2e tests #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
clusterclass-add-to-e2e
branch
from
e436804
to
c4dca18
Compare
salasberryfin
added
area/testing
salasberryfin
changed the title
salasberryfin
force-pushed
the
clusterclass-add-to-e2e
branch
6 times, most recently
from
164f430
to
9de5a73
Compare
salasberryfin
changed the title
salasberryfin
force-pushed
the
clusterclass-add-to-e2e
branch
2 times, most recently
from
0c2d645
to
086aa82
Compare
Signed-off-by: Carlos Salas <[email protected]>
salasberryfin
force-pushed
the
clusterclass-add-to-e2e
branch
from
086aa82
to
cd6644b
Compare
furkatgofurov7
approved these changes
Sep 4, 2024
Danil-Grigorev
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ClusterClass has been supported by CAPRKE2 for a number of releases now but we haven't added a dedicated test to validate this feature. As we add more ClusterClass samples and work on new operations, we need to make sure that we don't face any issues with the current implementation or any regressions.
This PR uses some of the existing features taken from upstream CAPI's test framework (and adapted to RKE2 control planes) and adds extra functionality on top of it to be able to apply custom templates. It may be interesting to create a
frameworkpackage, similar to the existing one upstream CAPI has for Kubeadm, with some of the helper functions. Currently it is all packed into a singlehelpers.gofile which may grow larger in the future.Which issue(s) this PR fixes:
Fixes #271
Special notes for your reviewer:
Checklist: