Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taint flag to cluster add-node command #320

Open
wants to merge 1 commit into
base: v2.6
Choose a base branch
from

Conversation

mouellet
Copy link

@mouellet mouellet commented Jul 7, 2022

On Rancher's cluster registration page, the one that shows you de node registration command, you have the options (Step 2) to add both node labels and taints. However, the cli cluster add-node command, which also prints the node registration command, only has a flag for node labels.

This Pull Request adds a flag for node taints to the cluster add-node command, printing a node registration command accordingly.

rancher cluster add-node --worker --taint key=value:NoSchedule
sudo docker run -d --privileged --restart=unless-stopped --net=host -v /etc/kubernetes:/etc/kubernetes -v /var/run:/var/run  rancher/rancher-agent:v2.6.5 --server https://redacted --token redacted --ca-checksum redacted --worker --taint key=value:NoSchedule

@mouellet
Copy link
Author

mouellet commented Jul 7, 2022

In light of rancher/rancher#36131, might need to use --taints as flag instead...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant