Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ksm/kubelet metricRelabeling issues. #2725

Open
wants to merge 2 commits into
base: dev-v2.7
Choose a base branch
from

Conversation

hansbogert
Copy link

Issue:

rancher/rancher#43402

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

Unsure

@danielpalstra
Copy link

This PR also addresses issue rancher/rancher#43396

@staerion
Copy link

This is still a problem for us that seems relatively easy to solve. Could someone please take the time to look at this PR?

@nicholasSUSE
Copy link
Collaborator

Hello @hansbogert
Is this Pull Request still relevant?
Can I close it?

@nickvth
Copy link

nickvth commented Feb 8, 2024

@nicholasSUSE @hansbogert and I can’t check if this is still relevant, because we stopped(many bugs) with using this chart. Maybe that other people still need this fix like @staerion.

@nicholasSUSE
Copy link
Collaborator

@nicholasSUSE @hansbogert and I can’t check if this is still relevant, because we stopped(many bugs) with using this chart. Maybe that other people still need this fix like @staerion.

Thank you.
@staerion could you take a look at this?

Copy link
Collaborator

@recena recena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is modifying rancher-kube-state-metrics but this chart does not exist anymore in dev-v2.7.

@recena
Copy link
Collaborator

recena commented Feb 14, 2024

I suggest to close this PR.

@nicholasSUSE
Copy link
Collaborator

I suggest to close this PR.

I agree, I will wait for @staerion response before closing it.

@alexandreLamarre
Copy link
Contributor

alexandreLamarre commented Feb 15, 2024

This PR is modifying rancher-kube-state-metrics but this chart does not exist anymore in dev-v2.7.

@recena @nicholasSUSE rancher-monitoring involves several sub-charts, kube-state-metrics is absolutely still an integral part of v2.7, I'd prefer if @joshmeranda and I take over the review of this one, since we are the team managing this line of features

@joshmeranda
Copy link
Contributor

I am going to second @alexandreLamarre here. We are probably better suited for this

@nicholasSUSE
Copy link
Collaborator

I am going to second @alexandreLamarre here. We are probably better suited for this

@alexandreLamarre @joshmeranda thank you for your response.

@michisee
Copy link

Is is still broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants