Skip to content

Commit

Permalink
Fixed some small issues for release Action
Browse files Browse the repository at this point in the history
Signed-off-by: Mohamed Belgaied Hassine <[email protected]>
  • Loading branch information
belgaied2 committed Jun 4, 2024
1 parent b3c51bb commit 764f8e0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
name: Feature request
about: Suggest an idea for the RKE2 Provider
about: Suggest an idea for the Harvester Provider
title: ''
labels: kind/feature, needs-priority, needs-triage
assigness: ''
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,4 @@ jobs:
name: ${{ env.TAG }}
files: |
out/metadata.yaml
out/bootstrap-components.yaml
out/control-plane-components.yaml
out/components.yaml
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ test: manifests generate fmt vet envtest ## Run tests.

##@ Build
.PHONY: manager
manager: ## Build the rke2 bootstrap manager binary into the ./bin folder
manager: ## Build the harvester manager binary into the ./bin folder
go build -trimpath -ldflags "$(LDFLAGS)" -o $(BIN_DIR)/manager github.com/rancher-sandbox/cluster-api-provider-harvester

.PHONY: build
Expand Down Expand Up @@ -237,6 +237,7 @@ $(RELEASE_DIR):
release: clean-release ## Build and push container images using the latest git tag for the commit
@if [ -z "${RELEASE_TAG}" ]; then echo "RELEASE_TAG is not set"; exit 1; fi
@if ! [ -z "$$(git status --porcelain)" ]; then echo "Your local git repository contains uncommitted changes, use git clean before proceeding."; exit 1; fi
$(MAKE) kustomize
git checkout "${RELEASE_TAG}"
# Build binaries first.
# GIT_VERSION=$(RELEASE_TAG) $(MAKE) release-binaries
Expand All @@ -263,7 +264,6 @@ release-manifests: $(RELEASE_DIR) $(KUSTOMIZE) ## Build the manifests to publish
# Build components.
$(KUSTOMIZE) build config/default > $(RELEASE_DIR)/components.yaml
$(MAKE) set-manifest-image MANIFEST_IMG=$(IMG) MANIFEST_TAG=$(TAG) TARGET_RESOURCE="$(RELEASE_DIR)/components.yaml"
# Build control-plane-components.

# Add metadata to the release artifacts
cp metadata.yaml $(RELEASE_DIR)/metadata.yaml
Expand Down

0 comments on commit 764f8e0

Please sign in to comment.