Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RKE2 ClusterClass and RKE2 default registration method #60

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

anmazzotti
Copy link
Collaborator

Adding the infrastructureRef to the RKE2ControlPlaneTemplate is a workaround for this issue.
I tested it against a local fresh build of the RKE2 provider, the Cluster Class should work on a next RKE2 provider release.

Also edited the registrationMethod to use control-plane-endpoint, since it's equivalent than using address and using the control plane endpoint address.

@anmazzotti anmazzotti requested a review from a team as a code owner May 31, 2024 12:32
Copy link
Contributor

@fgiudici fgiudici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good here!

@anmazzotti anmazzotti merged commit a2c4683 into rancher-sandbox:main Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants