Making it work out of the box #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laszewsk
reviewed
Jun 26, 2022
Hey I am sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I had to specify your images explicitly on dockerhub (e.g.
rancavil/slurm-jupyter:19.05.5-1instead ofslurm-jupyter:19.05.5-1) or that i had to add the build-definition in thedocker-compose.yml.I choose the latter since the docker-files are already provided and it gives people more flexibility.
I also think it might be a good idea to use local FS-mounts instead of Docker-Volumes because this allows people to add their slurm-jobs into their git-repos.
P.S.: Thanks for creating this repo .. It helped me a lot and I think I understand slurm better now