Skip to content

Conversation

Fale
Copy link

@Fale Fale commented Sep 6, 2014

As declared, if you merge this pull request, you can safely close bug report #2 since this is the actual code suggested in that bug pulll-requested

@Enrices
Copy link

Enrices commented Sep 17, 2014

Very useful fix but I disagree with the change in manage.py.

Firstly, this change should be done in settings.py (using for example BASE_DIR)
Secondly, this is important to wrap the new path with os.path.normpath(). If not, some OS will not recognize the URL foo/../bar and the system will crash.

I will suggest another fix. (I cannot change this one as it is not pulled yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants