Feature: WebSocket Client for Live Data Streaming #2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvan2006
force-pushed
the
feature/websocket
branch
from
38ee363 to
55b4a90
Compare
|
@ValueRaider any opinions on this websocket? Is it suitable for this package? |
R5dan
suggested changes
Jan 6, 2025
Comment on lines
+99
to
+102
| if self.is_running: | ||
| self.logger.warning("WebSocket is already running.") | ||
| print("WebSocket is already running.") | ||
| return |
There was a problem hiding this comment.
Why not "unsubscribe" from everything and then resubscribe to everything + this new ticker.
This would be easier for the user as this is what they ultimately will end up doing
Comment on lines
+105
to
+115
| try: | ||
| self.ws = create_connection(self.uri) | ||
| self.is_running = True | ||
|
|
||
| subscribe_message = {"subscribe": symbols} | ||
| self.ws.send(json.dumps(subscribe_message)) | ||
| self.logger.info("Subscribed to: %s", symbols) | ||
|
|
||
| self.listen() | ||
| except Exception as e: | ||
| self.logger.error("Failed to subscribe to symbols: %s", e, exc_info=True) |
There was a problem hiding this comment.
Let the user call listen, have this function return itself and just update the tickers.
| @@ -39,7 +39,8 @@ Yahoo! finance API is intended for personal use only.** | |||
| - `Ticker`: single ticker data | |||
| - `Tickers`: multiple tickers' data | |||
| - `download`: download market data for multiple tickers | |||
| - `Market`: get infomation about a market | |||
| - `WebSocket`: live streaming data for multiple tickers | |||
| - `Market`: get information about a market | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WebSocketclass to stream live market data.pricing.protoandpricing_pb2.py) for data de serialization.requirements.txtandsetup.pyto include new dependencies.Usage