Add Annual Net Expense Ratio to Ticker Info #1769
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Revert the last commit and rebase to |
ChNgineer
force-pushed
the
netER-info
branch
5 times, most recently
from
edeb77c to
4e7344a
Compare
updated base.py ticker to accommodate mutual funds and ETFs to show annualNetExpenseRatio in ticker.info
|
@ValueRaider branch is rebased, history is clean with single commit. |
|
Can you wrap the GET in a Regarding refactor, there is a plan #1755. |
ValueRaider
reviewed
Dec 10, 2023
| @@ -1751,6 +1751,10 @@ def get_mutualfund_holders(self, proxy=None, as_dict=False): | |||
| def get_info(self, proxy=None) -> dict: | |||
| self._quote.proxy = proxy or self.proxy | |||
| data = self._quote.info | |||
| if data['quoteType'] == 'ETF': | |||
There was a problem hiding this comment.
This excludes mutual funds (MUTUALFUND)
ChNgineer
force-pushed
the
netER-info
branch
from
ff314af to
443161d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for existence of 'Expense Ratio (net)' of mutual funds and ETF tickers and adds metric retroactively to
Ticker.infoattribute throughTickerBase.get_info()method as'annualNetExpenseRatio'as requested and resolves #801.Change uses
TickerBase.get_institutional_holders()which returns a dictionary with row info['Net Assets', 'NAV', 'PE Ratio (TTM)', 'Yield', 'YTD Daily Total Return', 'Beta (5Y Monthly)', 'Expense Ratio (net)', 'Inception Date']for mutual funds and ETF tickers.This may be a bug, as these dictionary contents have nothing to do with institutional holders of mutual funds and ETFs as they do not have any listed under Holdings. These stats are located on the summary page of mutual funds and ETFs on finance.yahoo.com see Vanguard 500 Index Fund (VOO) as example, Holdings tab of mutual funds and ETFs show Overall Portfolio Composition (%), Sector Weightings (%), Equity Holdings, Bond Ratings, and Top 9 Holdings.
From testing it shows that
TickerBaseclass methodsget_major_holders()returns information from the first column of the summary page andget_institutional_holders()returns information from the second column of the summary page for mutual funds and ETFs.This is a temporary fix, but further action will likely require a code refactor of considerable scale.