replace default parquet engine #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deprecate Fastparquet - enable Pyarrow as default engine Existing stores using fastparquet will require a manual update on metadata.json. "engine": "fastparquet" --> "engine": "pyarrow" Changes to be committed: modified: CHANGELOG.rst modified: README.rst modified: examples/pystore-tutorial.ipynb modified: meta.yaml modified: pystore/collection.py modified: pystore/item.py modified: pystore/store.py modified: requirements.txt modified: setup.py
- Rename metadata.json file to pystore_metadata.json, as it classes with pyarrow - Fix append. Dask does not support parquet write with overwrite on the same file. Added support for append by writing in temp directory. - Remove parameter chunksize as it's not used - Fix overwrite on collection.write
- update requirements, only needs dask[dataframe] - update CHANGELOG, state change in metadata.json required to avoid conflicts with pyarrow
Shadeun
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing stores using fastparquet will require a manual update on metadata.json.
"engine": "fastparquet" --> "engine": "pyarrow"
Changes to be committed:
modified: CHANGELOG.rst
modified: README.rst
modified: examples/pystore-tutorial.ipynb
modified: meta.yaml
modified: pystore/collection.py
modified: pystore/item.py
modified: pystore/store.py
modified: requirements.txt
modified: setup.py