Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHP 8.4 deprecation #590

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Fixed PHP 8.4 deprecation #590

wants to merge 1 commit into from

Conversation

PNardman
Copy link

@PNardman PNardman commented Mar 5, 2025

Description

Fixed deprecation warning for str_getcsv in php 8.4, since the default parameter will change, by providing the parameter explicitly.

Sidenote: some of the vendor packages still have the same issue with deprecation warnings when running code maintenance tools. They should be updated as well.

Closes #587

Motivation and context

Removing deprecation warnings, when upgrading to php 8.4

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@PNardman PNardman requested a review from ramsey as a code owner March 5, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8.4 Deprecation warning
1 participant