Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpg-plugin-version 3.2.7-SNAPSHOT to build pipeline #30

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

ralfkonrad
Copy link
Owner

No description provided.

@cstamas
Copy link

cstamas commented Sep 24, 2024

As expected, as 3.2.7 w/o passphraseLf config behaves exactly as previous 3.2.x releases. So maybe 3.2.7 needs to change defaults to passphraseLf=true (as non-Windows OS are not affected anyway).

@cstamas
Copy link

cstamas commented Sep 24, 2024

Updating PR and will deploy new SNAP that by def handles this. Stay tuned, as PR will needs to be triggered to pull new SNAPSHOT

@cstamas
Copy link

cstamas commented Sep 24, 2024

Pushed changes to PR apache/maven-gpg-plugin#120 (today's commit, no extra config will be needed anymore as explained in PR comment).

Will ping here once I deployed new snapshot to ASF snapshots.

@cstamas
Copy link

cstamas commented Sep 24, 2024

Deployed new snapshot version 3.2.7-20240924.100708-4 does does not need any extra config to make it work on Windows.

@ralfkonrad
Copy link
Owner Author

Will ping here once I deployed new snapshot to ASF snapshots.

Sure!

Don't know if this helps but I have included gpg-plugin-passphraseLf into the workflow matrix.

Also, after this workflow is merged, it will run scheduled in the night!

@cstamas
Copy link

cstamas commented Sep 24, 2024

Nice! The goal is to not "distinguish" OS, so GPG plugin should be able sign by default without extra quirks for Windows (like passphraseLf config is). Moreover, Michael proposed to rename this new parameter, please chime in:
apache/maven-gpg-plugin#120

@cstamas
Copy link

cstamas commented Sep 24, 2024

With latest snapshot, from matrix following bit should be removed:

        gpg-plugin-passphraseLf:
          - "true"
          - "false"

(and related config and so on), the plugin should "just work" as expected without any extra config. Plus, in latest snapshot the config passphraseLf will be renamed to terminatePassphrase and will be defaulted to true.

@ralfkonrad
Copy link
Owner Author

Now, it fails again. Have I missed something here?

@ralfkonrad
Copy link
Owner Author

ralfkonrad commented Sep 24, 2024

We had <updatePolicy>daily</updatePolicy> for the SNAPSHOT. Therefore, the latest version was not used as the actions/setup-java@v4 uses caching.

Now, it is working again. 🚀

This was referenced Sep 24, 2024
@ralfkonrad ralfkonrad merged commit da434f5 into master Sep 24, 2024
12 checks passed
@ralfkonrad
Copy link
Owner Author

@cstamas: I have merged this one. Let me know if we should try something else.

But for me it looks like you have solved the problem. 👏

Thanks for your effort, appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants